Move Validation before the Pipeline #462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucas0T
requested review from
juliangruendner,
alexanderkiel and
bastianschaffer
as code owners
Lucas0T
force-pushed
the
451-move-validation-before-the-pipeline
branch
from
06a1613 to
63166aa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
============================================
+ Coverage 85.12% 85.37% +0.25%
- Complexity 919 920 +1
============================================
Files 93 93
Lines 2789 2790 +1
Branches 292 292
============================================
+ Hits 2374 2382 +8
+ Misses 288 284 -4
+ Partials 127 124 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexanderkiel
requested changes
Sep 2, 2025
| response.expectStatus().isBadRequest().expectHeader().contentType("application/fhir+json") | ||
| .expectBody() | ||
| .jsonPath("$.resourceType").isEqualTo("OperationOutcome") | ||
| .jsonPath("$.issue[0].diagnostics").isEqualTo("IllegalArgumentException: Invalid CRTDL"); |
There was a problem hiding this comment.
The diagnostics should not contain any Java related artefacts like class names. So I would just remove IllegalArgumentException. "Invalid CRDTL" is good enough.
There was a problem hiding this comment.
ok then i change the whole generation
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class ResultFileManagerTest { | ||
| final String RESULTS_DIR = "ResultFileManagerDir"; |
|
|
||
| resultFileManager.saveErrorToJson(jobId, operationOutcome, HTTP_OK).block(); | ||
|
|
||
| assertThat(readJobErrorFile(jobId)).isEqualTo(fhirParser.encodeResourceToString(operationOutcome)); |
There was a problem hiding this comment.
A new parser has to be created for each parsing call.
| Assertions.fail("HTTP request failed with status code: " + e.getStatusCode()); | ||
| } | ||
|
|
||
| } catch (IOException e) { |
There was a problem hiding this comment.
please just throw exceptions from the test method. logging will not fail the test
Lucas0T
force-pushed
the
451-move-validation-before-the-pipeline
branch
from
0949e5e to
f649ec0
Compare
Lucas0T
force-pushed
the
451-move-validation-before-the-pipeline
branch
from
f649ec0 to
65a7165
Compare
juliangruendner
requested changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.